Should use Content-MD5 header on PUT

[ferrix]

Especially in light of http://developer.amazonwebservices.com/connect/thread.jspa?threadID=22709

[tienshiao]

I've added support for the Content-MD5 header. It seems to work OK for me.

Edit: in case people missed it, the patch is attached to the reply. You might need to be logged in to see it.

[ferrix]

Warning: the patch is backwards.

[ferrix]

Is there any reason you have done

Base64.encode64(md5.digest)

rather than

md5.hexdigest

or maybe I don't understand the difference properly..?

[tienshiao]

Oops, sorry about the backwards patch.

hexdigest returns the MD5 in hexidecimal representation [0-9A-F].

Amazon's docs specify Content-MD5 should be in base64 (http://en.wikipedia.org/wiki/Base64) .



In hindsight, there probably isn't a need for the commandline switch (--content-md5). There isn't a good reason not to use Content-MD5 if you're already calculating the MD5.

[ferrix]

I agree about the switch.  I know I need to add this feature.

[ferrix]

When I add this, I want it to be compatible with the --no-md5 option, so that when a transfer is needed it will calculate the md5 anyway (but not bother for just comparing the two trees)